Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCHv2 1/1] RTC:driver for Cortina's SOC | Date | Wed, 13 May 2015 21:05:54 +0200 |
| |
On Wednesday 13 May 2015 21:03:29 Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > To: Hans Ulli Kroll <ulli.kroll@googlemail.com> > CC: Paul Bolle <pebolle@tiscali.nl>, Alexandre Belloni <alexandre.belloni@free-electrons.com>, linux-kernel@vger.kernel.org > Date: Today 21:03:29 > On Wednesday 13 May 2015 20:23:40 Hans Ulli Kroll wrote: > > > I have a patch that will turn mach-gemini into multiplatform, and > > > at that point it will also fail there. The correct solution I think > > > is to move the GEMINI_RTC_SECOND etc definitions into rtc-gemini.c > > > itself and remove the #include. > > > > > > > GEMINI_RTC_SECOND and other register offset are in the driver. > > The only address I get from the #include is the base address of the RTC > > > > Ah, I see. Please pass a struct resource for this then when you call > platform_device_register_simple from the platform code, and > use platform_get_resource/devm_ioremap_resource to map it so you can > remove that inclusion.
I just saw that you already do this, so the #include should not be needed at all.
Arnd
| |