Messages in this thread | | | Date | Wed, 13 May 2015 17:54:16 +0100 | From | Sudeep Holla <> | Subject | Re: [PATCH] of: base: upgrade initcall level of of_init from core to pure |
| |
On 13/05/15 17:34, Rob Herring wrote: > On Wed, May 13, 2015 at 9:50 AM, Sudeep Holla <sudeep.holla@arm.com> wrote: >> On 13/05/15 14:46, Rob Herring wrote: >>> On Wed, May 13, 2015 at 5:03 AM, Sudeep Holla <sudeep.holla@arm.com> >>> wrote: > > [...] > >>>> Yes I read and was bit hesitant initially to do this change, but found >>>> no better way. I posted mainly to discuss other possibilities to solve >>>> the issue. >>> >>> >>> Perhaps of_init should not be an initcall at all and it should go into >>> driver_init(). >> >> >> That seems ideal place to me as most of kset and kobjects are created >> there. Something like below patch ? However found that PPC had a >> function with same name which can conflict and we need to rename one of >> these two. > > It looks like the PPC one is in the boot wrapper. They shouldn't > collide. If they do, then how about of_core_init. >
Thanks for the review, will check the PPC build and change accordingly if required.
Regards, Sudeep
| |