lkml.org 
[lkml]   [2015]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] mfd: da9052: fix broken regulator probe
    On Wed, 29 Apr 2015, Lee Jones wrote:

    > On Wed, 29 Apr 2015, Johan Hovold wrote:
    >
    > > On Tue, Apr 14, 2015 at 03:04:06PM +0200, Johan Hovold wrote:
    > > > Hi Mark and Lee,
    > > >
    > > > On Thu, Mar 26, 2015 at 08:32:09AM +0000, Lee Jones wrote:
    > > > > On Wed, 25 Mar 2015, Johan Hovold wrote:
    > > > >
    > > > > > Fix broken probe of da9052 regulators, which since commit b3f6c73db732
    > > > > > ("mfd: da9052-core: Fix platform-device id collision") use a
    > > > > > non-deterministic platform-device id to retrieve static regulator
    > > > > > information. Fortunately, adequate error handling was in place so probe
    > > > > > would simply fail with an error message.
    > > > > >
    > > > > > Update the mfd-cell ids to be zero-based and use those to identify the
    > > > > > cells when probing the regulator devices.
    > > > > >
    > > > > > Fixes: b3f6c73db732 ("mfd: da9052-core: Fix platform-device id collision")
    > > > > > Cc: stable <stable@vger.kernel.org> # v3.19
    > > > > > Signed-off-by: Johan Hovold <johan@kernel.org>
    > > > > > ---
    > > > > > drivers/mfd/da9052-core.c | 8 ++++----
    > > > > > drivers/regulator/da9052-regulator.c | 5 +++--
    > > > >
    > > > > Need an Ack from Mark, but looks good to me.
    > > > >
    > > > > Acked-by: Lee Jones <lee.jones@linaro.org>
    > > >
    > > > Mark, did you have a chance to look at this one?
    > > >
    > > > It fixes a regression due to an mfd commit, but not sure who of you that
    > > > wants to take it.
    > >
    > > It's now been over a month and this still hasn't been applied even
    > > though it fixes a regression.
    > >
    > > Lee, perhaps you should take it through MFD as it was an MFD commit that
    > > broke it?
    >
    > I'm in the same situation -- can't do anything without an Ack from Mark.

    I happen to know that Mark regularly deletes his mail.

    Can you re-sent this complete with collected Acks please?

    --
    Lee Jones
    Linaro STMicroelectronics Landing Team Lead
    Linaro.org │ Open source software for ARM SoCs
    Follow Linaro: Facebook | Twitter | Blog


    \
     
     \ /
      Last update: 2015-05-13 18:21    [W:3.932 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site