lkml.org 
[lkml]   [2015]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [rtc-linux] [PATCH V1 3/6] rtc: da9062: DA9062 RTC driver
    On 13/05/2015 at 06:04:47 -0700, Guenter Roeck wrote :
    > Don't know how this is handled for rtc drivers, but in other subsystems
    > we just live with the original name. I don't see a need to rename a driver
    > just because it starts supporting more hardware, and xxx is weird anyway
    > since it suggests everything from 000 to 999, which is much worse than
    > just sticking with 9063.
    >

    Yes, in particular if at some point in time a new IP matching those xxx
    is completely different from the previous one. I'm not fond of renaming
    the driver either but if diasemi thinks that what they want, I'm open to
    let it happen. But clearly, I don't want to end up in a situation like
    the tlv320aic where you don't know which driver correspond to which
    chip:

    sound/soc/codecs/tlv320aic31xx.c
    sound/soc/codecs/tlv320aic31xx.h
    sound/soc/codecs/tlv320aic32x4.c
    sound/soc/codecs/tlv320aic32x4.h
    sound/soc/codecs/tlv320aic3x.c
    sound/soc/codecs/tlv320aic3x.h
    sound/soc/codecs/tlv320dac33.c
    sound/soc/codecs/tlv320dac33.h

    Go figure that the tlv320aic3104 can be supported by both tlv320aic3x.c
    and tlv320aic32x4.c but not tlv320aic31xx.c...

    --
    Alexandre Belloni, Free Electrons
    Embedded Linux, Kernel and Android engineering
    http://free-electrons.com


    \
     
     \ /
      Last update: 2015-05-13 15:41    [W:3.886 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site