Messages in this thread | | | Date | Wed, 13 May 2015 07:32:33 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 01/12] target: Convert se_node_acl->device_list[] to RCU hlist |
| |
On Tue, May 12, 2015 at 10:08:51PM -0700, Nicholas A. Bellinger wrote: > The series is bisectable. With patch #1 in place ->device_list[] is > still kzalloc()'ed, but new RCU pointer assignments are made into > lun_entry_hlist[]. > > Squashing the RCU reader paths (#2-6) for merge is OK, but it's still > nice to break up reader / updater changes into separate patches.
Having the full data structure switch over in one patch really makes reviewing and understning the change a lot easier. But changes to say move to a mutex should indeed stay separate. So patches 1-6 really should be mostly one.
| |