Messages in this thread | | | Date | Wed, 13 May 2015 10:55:56 +0200 | From | David Hildenbrand <> | Subject | Re: [PATCH v1 11/15] arm/futex: UP futex_atomic_op_inuser() relies on disabled preemption |
| |
> * David Hildenbrand | 2015-05-13 09:38:12 [+0200]: > > >Thanks, I'll include it in the next version. > > > >So I assume the cleanest thing to do would be: > > > >#if __LINUX_ARM_ARCH__ < 6 > > preempt_disable(); > >#endif > > Correct. But also for futex_atomic_cmpxchg_inatomic() which also behind > CONFIG_SMP curtain. That is why I suggested a new patch :) > > >David > > Sebastian
Ah, okay I think now I got it :)
So both patches are fine for now, but we should replace CONFIG_SMP by __LINUX_ARM_ARCH__ >=6 in both file, not only in the code I touch (to make it map arch/arm/include/asm/cmpxchg.h style).
David
| |