lkml.org 
[lkml]   [2015]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH/RFC v6 4/7] PM / Domains: Add DT bindings for PM QoS device latencies
    From
    On 27 April 2015 at 14:43, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
    > PM QoS device start/stop are properties of the hardware.
    > In legacy code, they're specified from platform code.
    > On DT platforms, their values should come from DT.
    >
    > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    > ---
    > v6:
    > - Rebased on top of v4.1-rc1 for new RFC,
    >
    > v4:
    > - Drop save/restore state latencies, as they're Linux driver-specific,
    > - Change state to RFC, as this is put on hold,
    >
    > v3:
    > - No changes,
    >
    > v2:
    > - New.
    > ---
    > Documentation/devicetree/bindings/power/power_domain.txt | 6 ++++++
    > 1 file changed, 6 insertions(+)
    >
    > diff --git a/Documentation/devicetree/bindings/power/power_domain.txt b/Documentation/devicetree/bindings/power/power_domain.txt
    > index d659e5cb39be6057..32d1d3a399fe2a48 100644
    > --- a/Documentation/devicetree/bindings/power/power_domain.txt
    > +++ b/Documentation/devicetree/bindings/power/power_domain.txt
    > @@ -73,12 +73,18 @@ Required properties:
    > - power-domains : A phandle and PM domain specifier as defined by bindings of
    > the power controller specified by phandle.
    >
    > +Optional properties:
    > + - stop-latency: Stop latency of the device, in ns,
    > + - start-latency: Start latency of the device, in ns,
    > +

    What do you think of renaming these to "suspend-latency" and
    "resume-latency" instead? I think that better reflects their purpose.
    I have no strong opinion though.

    > Example:
    >
    > leaky-device@12350000 {
    > compatible = "foo,i-leak-current";
    > reg = <0x12350000 0x1000>;
    > power-domains = <&power 0>;
    > + stop-latency = <250000>;
    > + start-latency = <250000>;
    > };
    >
    > The node above defines a typical PM domain consumer device, which is located
    > --
    > 1.9.1
    >

    Kind regards
    Uffe


    \
     
     \ /
      Last update: 2015-05-13 11:21    [W:4.262 / U:0.524 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site