lkml.org 
[lkml]   [2015]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 05/12] target: Convert transport_lookup_*_lun to RCU reader
From
Date
On Wed, 2015-05-13 at 07:55 +0200, Christoph Hellwig wrote:
> > + rcu_read_lock();
> > + deve = target_nacl_find_deve(nacl, unpacked_lun);
> > + if (deve && deve->lun_flags & TRANSPORT_LUNFLAGS_INITIATOR_ACCESS) {
> > + /*
> > + * Make sure that target_enable_device_list_for_node()
> > + * has not already cleared the RCU protected pointers.
> > + */
> > + if (!deve->se_lun) {
>
> Just move the hlist_del_rcu in core_disable_device_list_for_node before
> clearing se_lun and this check won't be needed.
>
> And if you need ny check here just add it to the if so that there is
> no need for the goto. Same for the TMR path.
>

Done.

> As for the locking changes: I'd rather have the change to a mutex
> as a separate patch as that's different from the data structure
> changes.

Fair enough.

--nab



\
 
 \ /
  Last update: 2015-05-13 10:01    [W:0.063 / U:0.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site