Messages in this thread | | | Date | Wed, 13 May 2015 09:22:04 +0200 | From | Juergen Gross <> | Subject | Re: [PATCH 09/12] target: Convert se_portal_group->tpg_lun_list[] to RCU hlist |
| |
On 05/13/2015 08:24 AM, Christoph Hellwig wrote: > >> FIXME: Figure out how sbp-target se_lun usage should work > > The Xen usage also looks really weird. Maybe Juergen can explain what > scsiback_add_translation_entry is trying to do?
scsiback_add_translation_entry() makes the connection between a pvSCSI LUN configured by the xen tools in xenstore and a xen-scsiback target.
The xen tools specify the pvSCSI LUN via <device>:<lun>, with <device> being either the WWN of the target or an alias of that target specified in config_fs.
scsiback_add_translation_entry() searches all it's targets until a match is found and links the found tpg to the device specification of the xen guest.
> Note that I think both > sbp and xen really should be working on node ACLs. Right now both > of them oly supported autogenerated ACLs, so in practice it doesn't > matter, but keeping the data structure use clean is a goal on it's own.
I'd be fine with this, but I think I'll need some hints how to achieve this. I guess I have to specify .fabric_make_nodeacl and .fabric_drop_nodeacl like e.g. done in drivers/vhost/scsi.c ? Is there anything else I have to consider?
Juergen
| |