Messages in this thread | | | Date | Thu, 14 May 2015 11:04:15 +0800 | From | Herbert Xu <> | Subject | Re: [RFC v2 3/6] crypto: qat - address recursive dependency when fw signing is enabled |
| |
On Wed, May 13, 2015 at 11:23:53AM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" <mcgrof@suse.com> > > We're going to add firmware module signing support, but when we do > this we end up with the following recursive dependency. Fix this by > just depending on FW_LOADER, which is typically always enabled > anyway. We do this as a compromise for now as FW_LOADER is only > selectable when EXPERT is enabled and the recursive dependency issue > below is actually real and valid, its proper fix however requires > a bit of work. > > This technically means this change is likely welcomed for other > parts of the kernel but this is really only needed for now here.
Nack. Either fix kbuild or make every user of FW_LOADER use a dependency. Singling out a single crypto device makes zero sense.
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |