Messages in this thread | | | Subject | Re: [PATCH 1/4] Partially revert "powerpc: Remove duplicate cacheable_memcpy/memzero functions" | From | Scott Wood <> | Date | Wed, 13 May 2015 19:49:25 -0500 |
| |
On Tue, 2015-05-12 at 15:32 +0200, Christophe Leroy wrote: > This partially reverts > commit 'powerpc: Remove duplicate cacheable_memcpy/memzero functions > ("f909a35bdfb7cb350d078a2cf888162eeb20381c")'
I don't have that SHA. Do you mean b05ae4ee602b7dc90771408ccf0972e1b3801a35?
> Functions cacheable_memcpy/memzero are more efficient than > memcpy/memset as they use the dcbz instruction which avoids refill > of the cacheline with the data that we will overwrite.
I don't see anything in this patchset that addresses the "NOTE: The old routines are just flat buggy on kernels that support hardware with different cacheline sizes" comment.
-Scott
| |