lkml.org 
[lkml]   [2015]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2 v2] lib/vsprintf.c: Further simplify uuid_string()
From
Date
On Tue, 2015-05-12 at 09:57 -0400, George Spelvin wrote:
> > Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> >
> > You may want/need to include Andrew Morton in the cc-list to get these
> > picked up.
>
> Thank you; I sent it to you because I'm not sure who's really in charge
> of this.

Andrew generally gets these sorts of changes applied.

> >> + /* Insert the fixed punctuation */
> >> + uuid[23] = uuid[18] = uuid[13] = uuid[8] = '-';
> >> + uuid[36] = 0;
>
> > I think '\0' is more common.
>
> It's that way beause of it was replacing
>
> >> - *p = 0;
>
> But yes, I prefer the char constant, too. And it would be consistent with
> the rest of the file.

I think I did that "*p = 0;" because that's what
I normally use, but consistency is better.




\
 
 \ /
  Last update: 2015-05-12 19:21    [W:0.079 / U:0.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site