Messages in this thread | | | Date | Tue, 12 May 2015 18:02:40 +0200 | From | Oleksij Rempel <> | Subject | Re: [PATCH v4 2/2] pinctrl: asm9260: add pinctrl add device tree bindings documentation |
| |
Am 05.05.2015 um 16:46 schrieb Linus Walleij: > On Mon, Apr 6, 2015 at 11:04 AM, Oleksij Rempel <linux@rempel-privat.de> wrote: > >> Add device tree bindings documentation for Alphascale asm9260 pin controller >> >> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de> > > (...) >> +* Alphascale ASM9260 SoC pinctrl core driver >> + >> +The pinctrl driver enables Alphascale ASM9260 to configure pin multiplexing >> +to a specific function. >> + >> +Required properties for pinctrl driver: >> +- compatible: "alphascale,asm9260-pinctrl" >> +- reg: Register base of the MPP block and length. >> +- clocks: clock ids. >> +- clock-names: >> + * 1 "ahb" : AHB gating clock. > > This clock is usually called pclock, "apb_pclk" (amba peripheral bus > p clock, don't know what P is...) what name does this have on your > data sheet?
the datasheet uses only "AHB" or "ahb_clk". Since i use in other modules same name i would prefer to use one style :)
>> +The following generic properties as defined in pinctrl-bindings.txt are valid >> +to specify in a pin configuration subnode: >> +pins - the list of pins that properties in the node >> + apply to (either this or "groups" has to be >> + specified) >> +function - the mux function to select >> +bias-disable - disable any pin bias >> +bias-pull-up - pull up the pin. Supported only on GPIO0_* pins. >> +bias-pull-down - pull down the pin. Supported on all pins except of GPIO0_*. > > Generic bindings, nice. Put a reference to the file pinctrl-bindings.txt > to point this out.
Yea, it was already done, see ^^ - "The following generic properties as defined in pinctrl-bindings.txt" :)
-- Regards, Oleksij
[unhandled content-type:application/pgp-signature] | |