Messages in this thread | | | Date | Tue, 12 May 2015 08:40:44 +0200 | Subject | Re: [PATCH 1/2] tools lib traceevent: Export dynamic symbols used by traceevent plugins | From | Mathias Krause <> |
| |
On 11 May 2015 at 16:33, Jiri Olsa <jolsa@redhat.com> wrote: > On Mon, May 11, 2015 at 09:35:26AM +0000, He Kuang wrote: >> Traceevent plugins need dynamic symbols exported from libtraceevent.a, >> otherwise a dlopen error will occur during plugins loading. >> >> This patch uses dynamic-list-file to export dynamic symbols which will >> be used in plugins to perf executable. >> >> The problem is covered up if feature-libpython is enabled, because >> PYTHON_EMBED_LDOPTS contains '-Xlinker --export-dynamic' which adds all >> symbols to the dynamic symbol table. So we should reproduce the problem >> by setting NO_LIBPYTHON=1. > > there's was another patch taking the shortcut: > http://marc.info/?l=linux-kernel&m=142885447432384&w=2 > > it seems it's not merged yet, but I like this one better >
I don't care much as long as it get fixed -- either using the big hammer with -Wl,--export-dynamic or the fine grained approach using a symbol file.
Thanks, Mathias
| |