lkml.org 
[lkml]   [2015]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] alpha: Wire up missing syscalls
On Tue, May 12, 2015 at 08:59:52PM +1200, Michael Cree wrote:
> On Sun, May 10, 2015 at 02:33:36AM +0800, Chen Gang wrote:
> > The related warnings:
> >
> > CALL scripts/checksyscalls.sh
> > <stdin>:1238:2: warning: #warning syscall seccomp not implemented [-Wcpp]
> > <stdin>:1241:2: warning: #warning syscall getrandom not implemented [-Wcpp]
> > <stdin>:1244:2: warning: #warning syscall memfd_create not implemented [-Wcpp]
> > <stdin>:1247:2: warning: #warning syscall bpf not implemented [-Wcpp]
> > <stdin>:1250:2: warning: #warning syscall execveat not implemented [-Wcpp]
>
> Chen: Have you tested the syscalls you have wired up?
>
> I have a suspicion that more is required to wire up the seccomp
> syscall.

likewise sys_bpf judging by the absence of bpf_int_jit_compile and friends in arch/alpha
The weak symbols mean it probably compiles/links, but it doesn't actually do
anything, and now instead of -ENOSYS, anyone trying to actually use that syscall
on alpha will get weird results.

Shutting up warnings like this strikes me as the wrong thing to do.

Dave



\
 
 \ /
  Last update: 2015-05-12 17:01    [W:0.521 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site