lkml.org 
[lkml]   [2015]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V9 8/8] perf tools: handle PERF_RECORD_LOST_SAMPLES
    Em Tue, May 12, 2015 at 02:43:44PM +0200, Peter Zijlstra escreveu:
    > On Mon, May 11, 2015 at 06:27:58PM -0300, Arnaldo Carvalho de Melo wrote:
    > > I disagree, since the support is there, we need to have it in
    > > hists->events_stats[PERF_RECORD_LOST_SAMPLES].

    > > But that can be done in a follow up patch.

    > Agreed, it would be good to know of which event the samples got lost.

    > > It just came quickly to my attention because of all the discussion about
    > > where to store something (PERF_SAMPLE_ID via sample_type + sample_id_all)
    > > that doesn't get used in the patch that introduces it :-)
    > >
    > > I'll try to test this all tomorrow and will try to do the needed wiring
    > > to hists_evsel->hists->events_stats.
    > >
    > > All working I can push this all via my perf/core event, if PeterZ
    > > agrees and is ok with the kernel specific bits.
    >
    > I would like to carry these as there some conflicts with other patches I
    > have.

    So go ahead and do it, when it lands on tip I'll check and try to
    continue what was discussed here, thanks!

    - Arnaldo


    \
     
     \ /
      Last update: 2015-05-12 15:41    [W:2.278 / U:0.412 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site