lkml.org 
[lkml]   [2015]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net: ll_temac: Fix DMA map size bug
On 05/12/2015 08:03 AM, Julia Lawall wrote:
> On Tue, 12 May 2015, Michal Simek wrote:
>
>> DMA allocates skb->len instead of headlen
>> which is used for DMA.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> drivers/net/ethernet/xilinx/ll_temac_main.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
>> index ca640d04fd93..cfb6bdb37fdc 100644
>> --- a/drivers/net/ethernet/xilinx/ll_temac_main.c
>> +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
>> @@ -705,8 +705,8 @@ static int temac_start_xmit(struct sk_buff *skb, struct net_device *ndev)
>>
>> cur_p->app0 |= STS_CTRL_APP0_SOP;
>> cur_p->len = skb_headlen(skb);
>> - cur_p->phys = dma_map_single(ndev->dev.parent, skb->data, skb->len,
>> - DMA_TO_DEVICE);
>> + cur_p->phys = dma_map_single(ndev->dev.parent, skb->data,
>> + skb_headlen(skb), DMA_TO_DEVICE);
>
> I think you could align the later arguments with the right side of the
> parenthesis, as done in the original code.

Fixed and send v2.

Thanks,
Michal



\
 
 \ /
  Last update: 2015-05-12 08:41    [W:0.062 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site