Messages in this thread | | | Date | Tue, 12 May 2015 08:06:31 +0200 | From | Michal Simek <> | Subject | Re: [PATCH] net: ll_temac: Fix DMA map size bug |
| |
On 05/12/2015 08:03 AM, Julia Lawall wrote: > On Tue, 12 May 2015, Michal Simek wrote: > >> DMA allocates skb->len instead of headlen >> which is used for DMA. >> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >> --- >> >> drivers/net/ethernet/xilinx/ll_temac_main.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c >> index ca640d04fd93..cfb6bdb37fdc 100644 >> --- a/drivers/net/ethernet/xilinx/ll_temac_main.c >> +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c >> @@ -705,8 +705,8 @@ static int temac_start_xmit(struct sk_buff *skb, struct net_device *ndev) >> >> cur_p->app0 |= STS_CTRL_APP0_SOP; >> cur_p->len = skb_headlen(skb); >> - cur_p->phys = dma_map_single(ndev->dev.parent, skb->data, skb->len, >> - DMA_TO_DEVICE); >> + cur_p->phys = dma_map_single(ndev->dev.parent, skb->data, >> + skb_headlen(skb), DMA_TO_DEVICE); > > I think you could align the later arguments with the right side of the > parenthesis, as done in the original code.
Fixed and send v2.
Thanks, Michal
| |