Messages in this thread | | | Date | Tue, 12 May 2015 13:55:00 +0200 | Subject | Re: [PATCH] pinctrl: cherryview: Read triggering type from HW if not set when requested | From | Linus Walleij <> |
| |
On Tue, May 12, 2015 at 12:35 PM, Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
> If a driver does not set interrupt triggering type when it calls > request_irq(), it means use the pin as the hardware/firmware has > configured it. There are some drivers doing this. One example is > drivers/input/serio/i8042.c that requests the interrupt like: > > error = request_irq(I8042_KBD_IRQ, i8042_interrupt, IRQF_SHARED, > "i8042", i8042_platform_device); > > It assumes the interrupt is already properly configured. This is true in > case of interrupts connected to the IO-APIC. However, some Intel > Braswell/Cherryview based machines use a GPIO here instead for the internal > keyboard controller. > > This is a problem because even if the pin/interrupt is properly configured, > the irqchip ->irq_set_type() will never be called as the triggering flags > are 0. Because of that we do not have correct interrupt flow handler set > for the interrupt. > > Fix this by adding a custom ->irq_startup() that checks if the interrupt > has no triggering type set and in that case read the type directly from the > hardware and install correct flow handler along with the mapping. > > Reported-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy@intel.com> > Reported-by: Freddy Paul <freddy.paul@intel.com> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Patch applied for fixes.
Yours, Linus Walleij
| |