Messages in this thread | | | Date | Tue, 12 May 2015 14:27:13 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v2] staging: panel: fix stackdump |
| |
On Tue, May 12, 2015 at 04:45:44PM +0530, Sudip Mukherjee wrote: > if we load the module, unload and then again try to load the module, we > will get a stackdump. In the module_exit function we are unregistering > the device and releasing the parport. So when we reach the detach > function parport is already null and the unregister_reboot_notifier() > is never called. When we again try to load the module it again tries > register_reboot_notifier() and gives us a stackdump as its earlier > registration is still not removed. It was caused by the commit > <bb046fef9668baf1c4744a3c7aba05e15e44c9ac>.
The right format is:
commit bb046fef9668 ('staging: panel: register reboot')
It is in case human beings reading your description don't remember which patch bb046fef9668 was.
> Fix this by moving all the unregistering and releasing in the detach > function, which should be the ideal case as the detach will be called if > we try to unregister the driver or if the parport is removed. >
We also have the Fixes: tag.
Fixes: bb046fef9668 ('staging: panel: register reboot')
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
regards, dan carpenter
| |