Messages in this thread | | | Date | Tue, 12 May 2015 22:42:46 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH tip/core/rcu 4/4] netfilter: Fix list_entry_rcu usage |
| |
On Tue, 12 May 2015 15:46:27 -0700 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
> From: Patrick Marlier <patrick.marlier@gmail.com> > > Signed-off-by: Patrick Marlier <patrick.marlier@gmail.com> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > --- > net/netfilter/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/netfilter/core.c b/net/netfilter/core.c > index e6163017c42d..ad70195929a4 100644 > --- a/net/netfilter/core.c > +++ b/net/netfilter/core.c > @@ -166,7 +166,7 @@ int nf_hook_slow(struct sk_buff *skb, struct nf_hook_state *state) > /* We may already have this, but read-locks nest anyway */ > rcu_read_lock(); > > - elem = list_entry_rcu(&nf_hooks[state->pf][state->hook], > + elem = list_entry_rcu(nf_hooks[state->pf][state->hook].next, > struct nf_hook_ops, list);
Looks to be setting to the next element, not the current one.
-- Steve
> next_hook: > verdict = nf_iterate(&nf_hooks[state->pf][state->hook], skb, state,
| |