Messages in this thread | | | From | Stephan Mueller <> | Subject | Re: [PATCH v5 1/5] random: Async and sync API for accessing nonblocking_pool | Date | Mon, 11 May 2015 09:30:11 +0200 |
| |
Am Montag, 11. Mai 2015, 14:57:14 schrieb Herbert Xu:
Hi Herbert, > >There are two problems with this patch: > >1) The interface is way too complicated for a once off wait used >only during boot. Really there is no need for cancellations.
I will remove that in the next installment. But that means that the DRBG kernel module (or any other module) cannot be unloaded until the work completes. > >2) There is potential for deadlock because you schedule a work that >then sits around until the entropy is available. What if whatever >is generating that entropy used the same work thread in future? > >So I suggest instead an interface that simply schedules a work >when the entropy is available.
Are you suggesting to only leave get_blocking_random_bytes and have the caller implementing the appropriate synchronous wait or async work?
Ciao Stephan
| |