Messages in this thread | | | Date | Mon, 11 May 2015 10:41:21 -0400 (EDT) | Subject | Re: [PATCH V5 1/1] hv_netvsc: Use the xmit_more skb flag to optimize signaling the host | From | David Miller <> |
| |
From: KY Srinivasan <kys@microsoft.com> Date: Mon, 11 May 2015 08:59:53 +0000
> > >> -----Original Message----- >> From: Joe Perches [mailto:joe@perches.com] >> Sent: Sunday, May 10, 2015 10:58 PM >> To: KY Srinivasan >> Cc: davem@davemloft.net; netdev@vger.kernel.org; linux- >> kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de; >> apw@canonical.com; jasowang@redhat.com >> Subject: Re: [PATCH V5 1/1] hv_netvsc: Use the xmit_more skb flag to >> optimize signaling the host >> >> On Sun, 2015-05-10 at 21:08 -0700, K. Y. Srinivasan wrote: >> > Based on the information given to this driver (via the xmit_more skb flag), >> > we can defer signaling the host if more packets are on the way. This will >> help >> > make the host more efficient since it can potentially process a larger batch >> of >> > packets. Implement this optimization. >> >> trivia: >> >> I think that indirecting >> VMBUS_DATA_PACKET_FLAG_COMPLETTION_REQUESTED >> into a non-const temporary isn't very useful. >> >> Whenever overly long identifiers like VMBUS_<FOO> is used, >> I think that it'd be better to use it directly and ignore >> 80 column warnings. > > Thanks Joe; if Dave agrees, I can send v6 of this patch out.
Sure, respin a v6.
| |