Messages in this thread | | | Date | Mon, 11 May 2015 12:21:46 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v2 1/2] x86/setup: introduce setup_bultin_cmdline |
| |
On Mon, May 11, 2015 at 04:09:07PM +0600, Alexander Kuleshov wrote: > This patch introduces setup_builtin_cmdline function which appends/overrides > boot_command_line with the builtin_cmdline if CONFIG_CMDLINE_BOOL is set. > Previously this functional was in the setup_arch, but we need to move > it for getting actual command line as early as possible in the > arch/x86/kernel/head{32,64}.c for the earlyprintk setup. > > Changes: > > v2: function renamed from setup_cmdline to setup_builtin_cmdline to > avoid conflict with the setup_cmdline from the arch/x86/kernel/kexec-bzimage64.c > > Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com> > --- > arch/x86/include/asm/setup.h | 3 ++- > arch/x86/kernel/head32.c | 1 + > arch/x86/kernel/head64.c | 1 + > arch/x86/kernel/setup.c | 28 +++++++++++++++------------- > 4 files changed, 19 insertions(+), 14 deletions(-)
Use checkpatch for your patches, some of the issues it points out are valid:
ERROR: code indent should use tabs where possible #63: FILE: arch/x86/kernel/head32.c:34: + setup_builtin_cmdline();$
WARNING: please, no spaces at the start of a line #63: FILE: arch/x86/kernel/head32.c:34: + setup_builtin_cmdline();$
ERROR: code indent should use tabs where possible #75: FILE: arch/x86/kernel/head64.c:174: + setup_builtin_cmdline();$
WARNING: please, no spaces at the start of a line #75: FILE: arch/x86/kernel/head64.c:174: + setup_builtin_cmdline();$
ERROR: open brace '{' following function declarations go on the next line #87: FILE: arch/x86/kernel/setup.c:848: +void __init setup_builtin_cmdline(void) {
total: 3 errors, 3 warnings, 70 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or scripts/cleanfile
Your patch has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply. --
| |