Messages in this thread | | | Date | Mon, 11 May 2015 16:23:16 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 2/2] vsprintf: Add support for userspace strings |
| |
On Sun, 10 May 2015 13:16:22 -0700 Joe Perches <joe@perches.com> wrote:
> On Sun, 2015-05-10 at 22:11 +0200, Richard Weinberger wrote: > > Am 10.05.2015 um 22:09 schrieb Joe Perches: > > > On Sun, 2015-05-10 at 21:42 +0200, Richard Weinberger wrote: > > >> Add %pL format string to print userspace strings. > > >> It works like %s but does copy_from_user() instead > > >> of a memcpy(). > > > > > > I think this would be much simpler in a new > > > function rather than complicating string() > > > > -ENOPATCH. > > It's your patch, I'm just commenting on it. > > I'm not sure there's much value in it.
I can't say I'm terribly excited either. Are there any existing callsites which might use this? The %p namespace is already pretty crowded and if %pL is just for non-production developer debug use then it can reasonably live outside the main kernel tree...
| |