Messages in this thread | | | Date | Mon, 11 May 2015 23:39:08 +0200 | From | Andreas Färber <> | Subject | Re: [PATCH] Show proper respect for Heinrich Hertz by using the correct unit for frequency |
| |
Am 11.05.2015 um 15:19 schrieb Russell King - ARM Linux: > The SI unit of frequency is Hertz, named after Heinrich Hertz, and is > given the symbol "Hz" to denote this. "hz" is not the unit of frequency, > and is in fact meaningless. > > Fix arch/arm to correctly use "Hz", thereby acknowledging Heinrich Hertz > contribution to the modern world. > > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Nice. :) Since you're being exact, should it be "Hertz' contribution"?
> diff --git a/arch/arm/boot/dts/omap3-cm-t3517.dts b/arch/arm/boot/dts/omap3-cm-t3517.dts > index f5b5a1d96cd7..53ae04f9104d 100644 > --- a/arch/arm/boot/dts/omap3-cm-t3517.dts > +++ b/arch/arm/boot/dts/omap3-cm-t3517.dts > @@ -66,7 +66,7 @@ > > otg_drv_vbus: pinmux_otg_drv_vbus { > pinctrl-single,pins = < > - OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50Mhz_clk.usb0_drvvbus */ > + OMAP3_CORE1_IOPAD(0x2210, PIN_INPUT_PULLDOWN | MUX_MODE0) /* rmii_50MHz_clk.usb0_drvvbus */
This one looks like an identifier - did you check where it comes from and whether it needs to be fixed there as well?
> >; > }; >
Rest looks good,
Reviewed-by: Andreas Färber <afaerber@suse.de>
Cheers, Andreas
-- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg)
| |