lkml.org 
[lkml]   [2015]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert
    From
    Date
    On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote:
    > I'd also like to factor the "if EXPERT" off of all the prompts and into a
    > single scoped item wrapped around all of them, but kconfig doesn't have any way
    > to do that. "menuconfig" is just a hint, with no matching "endmenu" and no
    > implicit visibility; "menu" is scoped and has "visible if", but that would
    > create a separate option containing a menu, rather than a menu under EXPERT's
    > "Configure standard kernel features (expert users)". And "if EXPERT ... endif"
    > produces a dependency, not a prompt-visibility condition. So I think this
    > would require changes to the Kconfig language, to introduce either a scoped
    > "visible if EXPERT ... endvisible" or similar, or a scoped version of
    > menuconfig with a matching "endmenu" and implicit visibility (effectively a
    > "menu" statement with attached "config" rather than a "config" with a hint
    > "this might be a menu"). I'm leaning towards the latter.

    The behavior of menuconfig in this case is rather subtle. I must admit I
    never noticed it.

    The "visible" option to menus is little used, and I'm not really
    familiar with it. So, for what it's worth: would adding a new menu with
    visible if EXPERT

    attached to it, and putting all current
    prompt "Foo" if EXPERT

    entries in that menu roughly do what you want?

    > So I'll send a followup patch enhancing kconfig to improve this case,
    > but I think splitting this into a separate file is still worth it even
    > without that.

    Thanks,


    Paul Bolle



    \
     
     \ /
      Last update: 2015-05-11 23:41    [W:2.111 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site