lkml.org 
[lkml]   [2015]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ktime: Fix ktime_divns to do signed division
On Fri, 1 May 2015, John Stultz wrote:

> static inline u64 ktime_divns(const ktime_t kt, s64 div)
> {
> if (__builtin_constant_p(div) && !(div >> 32)) {
> - u64 ns = kt.tv64;
> + s64 ns = kt.tv64;
> + int neg = 0;
> +
> + if (ns < 0) {
> + neg = 1;
> + ns = -ns;
> + }

Minor comment: you could save some realestate with:

s64 ns = kt.tv64;
bool neg = (ns < 0);

if (neg)
ns = -ns;


Nicolas


\
 
 \ /
  Last update: 2015-05-02 02:41    [W:0.061 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site