Messages in this thread Patch in this message | | | From | Julia Lawall <> | Subject | [PATCH 17/20] Staging: lustre: osc: remove unneeded null test before free | Date | Fri, 1 May 2015 21:37:50 +0200 |
| |
Kfree can cope with a null argument, so drop null tests.
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression ptr; @@
- if (ptr != NULL) kfree(ptr); // </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
--- drivers/staging/lustre/lustre/osc/osc_request.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/osc/osc_request.c b/drivers/staging/lustre/lustre/osc/osc_request.c index 7ddf46b..ded184e 100644 --- a/drivers/staging/lustre/lustre/osc/osc_request.c +++ b/drivers/staging/lustre/lustre/osc/osc_request.c @@ -2064,8 +2064,7 @@ out: if (oa) OBDO_FREE(oa); - if (pga) - kfree(pga); + kfree(pga); /* this should happen rarely and is pretty bad, it makes the * pending list not follow the dirty order */ while (!list_empty(ext_list)) {
| |