Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [PATCH 2/5] sched: always use blk_schedule_flush_plug in io_schedule_out | Date | Fri, 01 May 2015 15:37:09 -0400 |
| |
Shaohua Li <shli@fb.com> writes:
> V2: don't change ->in_iowait > > Cc: NeilBrown <neilb@suse.de> > Signed-off-by: Shaohua Li <shli@fb.com> > --- > kernel/sched/core.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index f9123a8..1ab3d2d 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -4402,10 +4402,7 @@ long __sched io_schedule_timeout(long timeout) > long ret; > > current->in_iowait = 1; > - if (old_iowait) > - blk_schedule_flush_plug(current); > - else > - blk_flush_plug(current); > + blk_schedule_flush_plug(current); > > delayacct_blkio_start(); > rq = raw_rq();
Looks good to me.
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
| |