Messages in this thread | | | Date | Fri, 01 May 2015 11:25:45 -0700 | From | Laura Abbott <> | Subject | Re: [patch] ARM: fix module-bound check in setting page attributes |
| |
On 3/24/15 9:20 PM, Hillf Danton wrote: > It was introduced in commit f2ca09f381a59 > (ARM: 8311/1: Don't use is_module_addr in setting page attributes) > > We have no need to check start twice, but see if end is also in range. > > Signed-off-by: Hillf Danton <hillf.zj@alibaba-inc.com> > --- > > --- a/arch/arm/mm/pageattr.c Wed Mar 25 11:55:13 2015 > +++ b/arch/arm/mm/pageattr.c Wed Mar 25 11:57:31 2015 > @@ -52,7 +52,7 @@ static int change_memory_common(unsigned > if (start < MODULES_VADDR || start >= MODULES_END) > return -EINVAL; > > - if (end < MODULES_VADDR || start >= MODULES_END) > + if (end < MODULES_VADDR || end >= MODULES_END) > return -EINVAL; > > data.set_mask = set_mask; > -- > >
Sorry for the delay, that e-mail address is being phased out. Please remember to Cc linux-arm-kernel when sending anything in arch/arm. If this hasn't been picked up, please resend with linux-arm-kernel Cc'ed and you can add
Acked-by: Laura Abbott <laura@labbott.name>
| |