Messages in this thread | | | Date | Fri, 1 May 2015 20:05:30 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree |
| |
On Fri, May 01, 2015 at 05:38:49PM +0000, Simmons, James A. wrote: > >From: Julia Lawall <Julia.Lawall@lip6.fr> > > > >Replace OBD_ALLOC, OBD_ALLOC_WAIT, OBD_ALLOC_PTR, and OBD_ALLOC_PTR_WAIT by > >kalloc/kcalloc, and OBD_FREE and OBD_FREE_PTR by kfree. > > Nak: James Simmons <jsimmons@infradead.org> > > A simple replace will not work. The OBD_ALLOC and OBD_FREE functions allocate memory > anywhere from one page to 4MB in size.
OBD_FREE() just calls kfree(), it does not allocate any memory, so that replacement is always ok.
thanks,
greg k-h
| |