lkml.org 
[lkml]   [2015]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] blk-mq: fix plugging in blk_sq_make_request
> -	if (use_plug && !blk_queue_nomerges(q) &&
> + if (likely(!is_flush_fua) && !blk_queue_nomerges(q) &&

Please don't sprinkle likely annotations for no go reason. Especially
on metadata write heavy workloads (e.g. an NFS server) it might be very
likely.


\
 
 \ /
  Last update: 2015-05-01 20:01    [W:0.186 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site