Messages in this thread | | | From | Gabriele Mazzotta <> | Subject | Re: [PATCH] iio: acpi: Add ACPI0008 Ambient Light Sensor | Date | Fri, 01 May 2015 18:12:14 +0200 |
| |
Hi,
probably this is not completely related to this driver, but I noticed something while testing it.
When I load acpi-als, /sys/bus/iio/devices/iio:device0/buffer/enable is 0. If I try to set it to 1, I get the following error: "Buffer not started: buffer parameter update failed (-22)"
After I got the error, I can successfully toggle "enable".
What I found is that the first time iio_request_update_kfifo() is called, __iio_allocate_kfifo() gets called. Since bytes_per_datum is 0 (as set iio_compute_scan_bytes()), it returns -EINVAL and so does iio_request_update_kfifo(), causing the error above.
Subsequent calls of iio_request_update_kfifo() will return 0 as update_needed is false, so "enable" can be toggled with no errors.
Isn't there something wrong here?
Regards, Gabriele
| |