Messages in this thread | | | Date | Thu, 9 Apr 2015 11:27:59 +0800 | From | Baoquan He <> | Subject | Re: [PATCH V2] x86/numa: kernel stack corruption fix |
| |
On 04/08/15 at 11:09am, Dave Young wrote: > On 04/08/15 at 10:41am, Xishi Qiu wrote: > > >> Hi Dave, > > >> > > >> I made a mistake, when numa is on, numa_meminfo is from SRAT, but it will be cut > > >> in numa_cleanup_meminfo(), so the bug is not related to numa on/off. Your comment > > >> is right. > > > > > > Hi Xishi, > > > > > >>From code flow it's exact as you said. And if remove numa=off bug should > > > be reproduced alwasy. I talked to Dave, he said error didn't occur when > > > he remove numa=off. That is too weird. > > > > > > > Hi Baoquan, > > > > May be it wrote over end of numa mask bitmap, but the stack can still run, > > so there is no Call Trace. > > How about add some printk to see if it has written over? > > Oops, Redhat kdump always add numa=off in 2nd kernel commandline, but I did > not notice I removed it during test. > > So yes, the issue does not depend on numa=off.
OK, got it. thanks. Ack this patch.
Acked-by: Baoquan He <bhe@redhat.com>
Thanks Baoquan
| |