lkml.org 
[lkml]   [2015]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2 v2] x86_64/earlyprintk: setup earlyprintk as early as possible
From
2015-04-07 22:49 GMT+06:00 Alexander Kuleshov <kuleshovmail@gmail.com>:
> * 2015-04-07 20:03 GMT+06:00 Ingo Molnar <mingo@kernel.org>:
>>
>> Yes, you need to check how and where in the arch init code
>> boot_command_line is set up in the CONFIG_CMDLINE_OVERRIDE=y case.
>>
>
> arch setup code defines builtin_cmdline and initalizes it with
> CONFIG_CMDLINE, which
> is 'root=/dev/sdb earlyprintk=ttyS0 loglevel=7 debug rdinit=/sbin/init
> root=/dev/ram memblock=debug' string in my test. During kernel
> initialization (int setup_arch),
> builtin_cmdline copying to the boot_command_line if CONFIG_CMDLINE_OVERRIDE and
> CONFIG_CMDLINE_BOOL are set.
>
> I think that it is not correct to pass boot_command_line to the
> setup_early_printk in
> CONFIG_CMDLINE_OVERRIDE=y case. As boot_command_line will be overwritten with
> builtin_cmdline.
>
> What do you think if we'll builtin_cmdline from the
> arch/x86/kernel/setup.c to the init.h to
> make it visible for head_{32,64}.c and pass builtin_cmdline or
> boot_command_line to
> the setup_early_printk depend on CONFIG_CMDLINE_OVERRIDE?

No, it's the wrong way. CONFIG_CMDLINE_BOOL can be 'y', but
CONFIG_CMDLINE_OVERRIDE
will be 'n', and boot_command_line will be appended, but not overwritten


\
 
 \ /
  Last update: 2015-04-07 19:41    [W:0.036 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site