Messages in this thread | | | Date | Tue, 7 Apr 2015 13:32:33 +0600 | Subject | Re: [PATCH] x86/boot: use __noreturn instead of directly __attribute__ definition | From | Alexander Kuleshov <> |
| |
Hello Andreas,
> > IMHO explicitly #include:ing parts > which certain code does actively depend on after all > is both a "code honesty" > and a documentation issue ("Hmm, which interfaces does this implementation > depend on? Ah, yeah...") >
Yes, before the patch i was in hesitancy, how to be with 'includes'. To add linux/compiler.h to the boot.h or do not do it as it already in the bitops.h. That's why I have added note about in to the commit message, for getting feedback about this.
Thank you.
| |