Messages in this thread | | | Subject | Re: [PATCH] mac80211: Move message tracepoints to their own header | From | Johannes Berg <> | Date | Tue, 07 Apr 2015 08:58:58 +0200 |
| |
On Mon, 2015-04-06 at 23:13 -0400, Steven Rostedt wrote: > Every tracing file must have its own TRACE_SYSTEM defined.
Oh, that requirement is new to me. I also have the same in iwlwifi, with even more TRACE_SYSTEMs.
> The mac80211 tracepoint header broke this and add in the middle > of the file had: > > #undef TRACE_SYSTEM > #define TRACE_SYSTEM mac80211_msg > > Unfortunately, this broke new code in the ftrace infrastructure. > Moving the mac80211_msg into its own trace file with its own > TRACE_SYSTEM defined fixes the issue.
> Cc: Johannes Berg <johannes@sipsolutions.net> > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Looks fine to me.
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
I could merge through my tree but I guess you'll want to put it through a different one to be able to change the code that depends on this move.
johannes
| |