Messages in this thread | | | Date | Tue, 7 Apr 2015 10:02:08 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 9/9] tools lib traceevent: Honor operator priority |
| |
Em Tue, Apr 07, 2015 at 04:52:26PM +0900, Namhyung Kim escreveu: > On Mon, Apr 06, 2015 at 10:45:04AM -0400, Steven Rostedt wrote: > > > type = process_arg_token(event, right, tok, type); > > > - arg->op.right = right; > > > + > > > + if (right->type == PRINT_OP && > > > + get_op_prio(arg->op.op) < get_op_prio(right->op.op)) { > > > + struct print_arg tmp; > > > + > > > + /* swap ops according to the priority */
> > This isn't really a swap. Better term to use is "rotate".
> You're right!
> > But other than that,
> > Acked-by: Steven Rostedt <rostedt@goodmis.org> > > Thanks for the review
Ok, so just doing that s/swap/rotate/g, sticking Rostedt's ack and applying, ok?
- Arnaldo
| |