lkml.org 
[lkml]   [2015]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: vdso: fix pvclock races with task migration
2015-04-07 13:11+0200, Paolo Bonzini:
> On 02/04/2015 20:44, Radim Krčmář wrote:
> > If we were migrated right after __getcpu, but before reading the
> > migration_count, we wouldn't notice that we read TSC of a different
> > VCPU, nor that KVM's bug made pvti invalid, as only migration_count
> > on source VCPU is increased.
> >
> > Change vdso instead of updating migration_count on destination.
> >
> > Fixes: 0a4e6be9ca17 ("x86: kvm: Revert "remove sched notifier for cross-cpu migrations"")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
>
> Applying this, but removing the "Fixes" tag because a guest patch cannot
> fix a host patch (it can work around it or complement it).

I think it was correct. Both are guest only, the revert just missed
some races. (0a4e6be9ca17 has misleading commit message ...)


\
 
 \ /
  Last update: 2015-04-07 15:01    [W:0.069 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site