Messages in this thread | | | Date | Tue, 07 Apr 2015 14:38:08 +0200 | From | Paolo Bonzini <> | Subject | Re: [PATCH v2 4/4] KVM: x86: simplify kvm_apic_map |
| |
On 12/02/2015 19:41, Radim Krčmář wrote: > +static inline void > +apic_logical_id(struct kvm_apic_map *map, u32 dest_id, u16 *cid, u16 *lid) > +{ > + BUILD_BUG_ON(KVM_APIC_MODE_XAPIC_CLUSTER != 4); > + BUILD_BUG_ON(KVM_APIC_MODE_XAPIC_FLAT != 8); > + BUILD_BUG_ON(KVM_APIC_MODE_X2APIC != 16); > +
I added
unsigned lid_bits = map->mode;
here (used in the rest of apic_logical_id) and applied the series.
Thanks,
Paolo
> + *cid = dest_id >> map->mode; > + *lid = dest_id & ((1 << map->mode) - 1); > +}
| |