Messages in this thread | | | Date | Wed, 8 Apr 2015 09:59:04 +0800 | From | Xishi Qiu <> | Subject | Re: [PATCH V2] x86/numa: kernel stack corruption fix |
| |
On 2015/4/8 9:46, Dave Young wrote:
>>> >>> - /* Mark all kernel nodes. */ >>> + /* >>> + * Mark all kernel nodes. >>> + * >>> + * In case booting with mem=nn[kMG] or in kdump kernel, numa_meminfo >> >> Hi Dave, >> >> It should both set mem=xx and numa=off, then numa_meminfo may not include all >> the memblock.reserved memory, right? > > Yasuaki Ishimatsu suggests to remove numa=off in comment because in theory there's such > possiblity that it may happen even without numa=off. Just consider the non-snb board.. > > Thanks > Dave >
Hi Dave,
I made a mistake, when numa is on, numa_meminfo is from SRAT, but it will be cut in numa_cleanup_meminfo(), so the bug is not related to numa on/off. Your comment is right.
Reviewed-by: Xishi Qiu <qiuxishi@huawei.com>
> . >
| |