Messages in this thread | | | Date | Tue, 7 Apr 2015 09:59:46 +0800 | Subject | Re: [PATCH 5/6] block: dasd_genhd: convert to blkdev_reread_part | From | Ming Lei <> |
| |
On Mon, Apr 6, 2015 at 9:51 PM, Jarod Wilson <jarod@redhat.com> wrote: >> >> Note: patch 6/6 in the series makes this whole while() loops pointless, >> since the possibility of the -EBUSY return goes away. > > Minor clarification: the -EBUSY due to the trylock, which is why that > retry loop exists, goes away. You *could* still get an -EBUSY through > blkdev_reread_part()->rescan_partitions()->drop_partitions() if > bdev->bd_part_count is non-zero.
Not like trylock(&bd_mutex), Inside kernel, it should be driver's responsibility to avoid that before rescanning partitions, that said retry may not be needed for this case.
Thanks,
| |