Messages in this thread | | | Subject | Re: [PATCH V2] tty: serial: Add const to struct uart_ops declarations | From | Joe Perches <> | Date | Sun, 05 Apr 2015 17:16:14 -0700 |
| |
On Mon, 2015-04-06 at 01:09 +0200, Stefan Agner wrote: > On 2015-04-05 20:24, Joe Perches wrote: > > Still compiled only x86 and not cross-compiled or tested. > > Cross-compiled with multi_v7_defconfig [] > > drivers/tty/serial/fsl_lpuart.c | 4 ++-- > > Tested that driver on actual hardware, looks fine.
> This driver seems to alter the startup function on initialization: > > CC drivers/video/of_display_timing.o > ../drivers/tty/serial/samsung.c: In function 's3c24xx_serial_init_port': > ../drivers/tty/serial/samsung.c:1702:3: error: assignment of member > 'startup' in read-only object > s3c24xx_serial_ops.startup = s3c64xx_serial_startup; > ^
Thanks Stefan. Then that one can't be const.
> That is the only thing which popped up with multi_v7_defconfig.
I appreciate the testing.
Greg, Jiri, I'll resend with this fixed in a week or so after waiting for any other comment or sign of brokenness.
| |