Messages in this thread | | | Date | Sun, 5 Apr 2015 14:48:33 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH] Input: atkbd: Fix release quirk for Dell models |
| |
Hi Pali,
On Sun, Mar 29, 2015 at 04:36:19PM +0200, Pali Rohár wrote: > This patch fixes commit 61579ba83934 ("Input: atkbd - expand Latitude's force > release quirk to other Dells"). Before that commit release quirks were called > for all Dell Latitude models. After that commit only for Portable Dell devices. > But lot of Latitude models are Laptop or Notebook DMI devices so quirks are not > called. > > Release quirks are still needed also for new Dell Latitude models, so this patch > enables quirks for all Portable, Laptop, Notebook and Sub-Notebook Dell devices.
Does Dell use all these types for their laptops? What models do you know that need this quirk?
Thanks.
> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > --- > drivers/input/keyboard/atkbd.c | 48 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > > diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c > index 387c51f..3188493 100644 > --- a/drivers/input/keyboard/atkbd.c > +++ b/drivers/input/keyboard/atkbd.c > @@ -1664,6 +1664,30 @@ static const struct dmi_system_id atkbd_dmi_quirk_table[] __initconst = { > }, > { > .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_CHASSIS_TYPE, "9"), /* Laptop */ > + }, > + .callback = atkbd_setup_forced_release, > + .driver_data = atkbd_dell_laptop_forced_release_keys, > + }, > + { > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_CHASSIS_TYPE, "10"), /* Notebook */ > + }, > + .callback = atkbd_setup_forced_release, > + .driver_data = atkbd_dell_laptop_forced_release_keys, > + }, > + { > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_CHASSIS_TYPE, "14"), /* Sub-Notebook */ > + }, > + .callback = atkbd_setup_forced_release, > + .driver_data = atkbd_dell_laptop_forced_release_keys, > + }, > + { > + .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"), > DMI_MATCH(DMI_CHASSIS_TYPE, "8"), /* Portable */ > }, > @@ -1672,6 +1696,30 @@ static const struct dmi_system_id atkbd_dmi_quirk_table[] __initconst = { > }, > { > .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"), > + DMI_MATCH(DMI_CHASSIS_TYPE, "9"), /* Laptop */ > + }, > + .callback = atkbd_setup_forced_release, > + .driver_data = atkbd_dell_laptop_forced_release_keys, > + }, > + { > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"), > + DMI_MATCH(DMI_CHASSIS_TYPE, "10"), /* Notebook */ > + }, > + .callback = atkbd_setup_forced_release, > + .driver_data = atkbd_dell_laptop_forced_release_keys, > + }, > + { > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"), > + DMI_MATCH(DMI_CHASSIS_TYPE, "14"), /* Sub-Notebook */ > + }, > + .callback = atkbd_setup_forced_release, > + .driver_data = atkbd_dell_laptop_forced_release_keys, > + }, > + { > + .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > DMI_MATCH(DMI_PRODUCT_NAME, "HP 2133"), > }, > -- > 1.7.9.5 >
-- Dmitry
| |