Messages in this thread | | | Date | Sat, 4 Apr 2015 15:36:47 +0200 | From | Jonathan Corbet <> | Subject | Re: [PATCH] [media] marvell-ccic: fix memory leak on failure path in cafe_smbus_setup() |
| |
On Sat, 4 Apr 2015 03:16:01 +0300 Alexey Khoroshilov <khoroshilov@ispras.ru> wrote:
> If i2c_add_adapter() fails, adap is not deallocated. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Actually, the worse thing is that it leaves the IRQ enabled...it's good you moved that lines down. Even better, of course, that the failure path has probably never been run during the life of this driver...:)
Should there be some sort of proper reported-by line for the driver verification project?
Acked-by: Jonathan Corbet <corbet@lwn.net>
jon
| |