lkml.org 
[lkml]   [2015]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [media] marvell-ccic: fix memory leak on failure path in cafe_smbus_setup()
On Sat,  4 Apr 2015 03:16:01 +0300
Alexey Khoroshilov <khoroshilov@ispras.ru> wrote:

> If i2c_add_adapter() fails, adap is not deallocated.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>

Actually, the worse thing is that it leaves the IRQ enabled...it's good
you moved that lines down. Even better, of course, that the failure path
has probably never been run during the life of this driver...:)

Should there be some sort of proper reported-by line for the driver
verification project?

Acked-by: Jonathan Corbet <corbet@lwn.net>

jon


\
 
 \ /
  Last update: 2015-04-04 16:01    [W:0.239 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site