Messages in this thread | | | Date | Sat, 4 Apr 2015 22:31:26 +0300 (EEST) | From | Giedrius Statkevičius <> | Subject | Re: [PATCH] staging: sm7xxfb: Fix sparse warning |
| |
On Sat, 4 Apr 2015, Nickolaus Woodruff wrote:
> This patch fixes the following sparse warning in sm7xx.h: > > drivers/staging/sm7xxfb/sm7xx.h:122:17: warning: symbol 'vgamode' > was not declared. Should it be static? > > Signed-off-by: Nickolaus Woodruff <nickolauswoodruff@gmail.com> > --- > drivers/staging/sm7xxfb/sm7xx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/sm7xxfb/sm7xx.h b/drivers/staging/sm7xxfb/sm7xx.h > index 7cc1896..c5d6253 100644 > --- a/drivers/staging/sm7xxfb/sm7xx.h > +++ b/drivers/staging/sm7xxfb/sm7xx.h > @@ -119,7 +119,7 @@ struct ModeInit { > /********************************************************************** > SM712 Mode table. > **********************************************************************/ > -struct ModeInit vgamode[] = { > +static struct ModeInit vgamode[] = {
Someone already fixed this: https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/sm7xxfb/sm7xx.h?h=staging-testing#n122 Please work against staging-testing branch of the staging tree.
Su pagarba / Regards, Giedrius
| |