Messages in this thread | | | Date | Thu, 30 Apr 2015 15:43:37 -0700 | From | Leonid Yegoshin <> | Subject | Re: [PATCH] MIPS64: R6: R2 emulation bugfix |
| |
On 04/29/2015 02:49 AM, Maciej W. Rozycki wrote: > On Wed, 29 Apr 2015, James Hogan wrote: > >>> Error recovery pointers for fixups was improperly set as ".word" >>> which is unsuitable for MIPS64. >>> >>> Replaced by __stringify(PTR) >> Every other case of this sort of thing uses STR(PTR) (or __UA_ADDR in >> uaccess.h). Can we stick to STR(PTR) for consistency please? > Or __PA_ADDR in paccess.h. > > I have mixed feelings, the reason for __stringify being absent is the > macro being generic and more recently added than pieces of code that use > STR, e.g. unaligned.c that has been there since forever. And we do use > __stringify in many other cases. > > On the other hand STR is short and sweet, unlike __stringify. > > So how about adding a macro like __STR_PTR that expands to > __stringify(PTR) and converting all the places throughout our port > (including ones currently using __UA_ADDR/__PA_ADDR) to use the new macro? > > Leonid's bug fix will need to go in first of course. > > Maciej As for me, I don't mind which solution is - STR/__stringify or __PA_ADDR. I just would like to have one for future submissions and I assumed that __stringify is it because it a last one so far introduced.
So, I put a decision to maintainer. Ralf?
- Leonid.
| |