Messages in this thread | | | Date | Thu, 30 Apr 2015 22:46:15 +0200 | From | Sebastian Hesselbarth <> | Subject | Re: [PATCH 3/4] clk: si5351: Do not pass struct clk in platform_data |
| |
On 30.04.2015 21:16, Fabio Estevam wrote: > On Thu, Apr 30, 2015 at 3:44 PM, Sebastian Hesselbarth > <sebastian.hesselbarth@gmail.com> wrote: >> Michael is right, the check is for bailing out if none of the parent >> clocks is available. > > + if (IS_ERR(drvdata->pxtal) && IS_ERR(drvdata->pclkin)) { > + dev_err(&client->dev, "missing at least one parent clock\n"); > + return -EINVAL; > + } > > Then shouldn't the error message be: "missing both parent clocks\n" ?
Yeah, probably. I'll reword the error message and also check the variant as only 5351C can have a "clkin" parent clock.
Sebastian
| |