lkml.org 
[lkml]   [2015]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC v1 3/5] clk: remove unneeded __clk_enable and __clk_disable
    On 04/15/15 07:26, Dong Aisheng wrote:
    > The only thing __clk_enable/__clk_disable does is NULL pointer checking
    > of clk except calling clk_core_{enable|disable} which is already handled
    > by clk_core_{enable|disable}.
    > So remove this unneeded function.
    >
    > Cc: Mike Turquette <mturquette@linaro.org>
    > Cc: Stephen Boyd <sboyd@codeaurora.org>
    > Signed-off-by: Dong Aisheng <aisheng.dong@freescale.com>
    > ---

    No. You can call clk_enable() and clk_disable() with NULL and it should
    be a no-op. With this change it would cause a NULL pointer exception.

    --
    Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
    a Linux Foundation Collaborative Project



    \
     
     \ /
      Last update: 2015-04-30 21:41    [W:4.953 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site