lkml.org 
[lkml]   [2015]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 3/4] clk: si5351: Do not pass struct clk in platform_data
    From
    On Thu, Apr 30, 2015 at 2:45 PM, Sebastian Hesselbarth
    <sebastian.hesselbarth@gmail.com> wrote:

    > * property silabs,pll-source : <num src>, [<..>]
    > * allow to selectively set pll source
    > @@ -1328,8 +1321,17 @@ static int si5351_i2c_probe(struct i2c_client *client,
    > i2c_set_clientdata(client, drvdata);
    > drvdata->client = client;
    > drvdata->variant = variant;
    > - drvdata->pxtal = pdata->clk_xtal;
    > - drvdata->pclkin = pdata->clk_clkin;
    > + drvdata->pxtal = devm_clk_get(&client->dev, "xtal");
    > + drvdata->pclkin = devm_clk_get(&client->dev, "clkin");
    > +
    > + if (PTR_ERR(drvdata->pxtal) == -EPROBE_DEFER ||
    > + PTR_ERR(drvdata->pclkin) == -EPROBE_DEFER)
    > + return -EPROBE_DEFER;
    > +
    > + if (IS_ERR(drvdata->pxtal) && IS_ERR(drvdata->pclkin)) {

    Don't you want || instead?


    \
     
     \ /
      Last update: 2015-04-30 20:41    [W:4.582 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site